clintropolis commented on issue #6662: Double-checked locking bugs URL: https://github.com/apache/incubator-druid/pull/6662#issuecomment-443908252 > @kamaci note that you must not force push PR branch: https://github.com/apache/incubator-druid/blob/master/CONTRIBUTING.md#if-your-pull-request-shows-conflicts-with-master I feel like maybe this is a bit less important now since github has added history for force pushes https://blog.github.com/changelog/2018-11-15-force-push-timeline-event/, at least as long as squashing/fixing are not done, unless there are other reasons I'm missing.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
