leventov commented on a change in pull request #6662: Double-checked locking
bugs
URL: https://github.com/apache/incubator-druid/pull/6662#discussion_r239126187
##########
File path:
processing/src/main/java/org/apache/druid/query/aggregation/JavaScriptAggregatorFactory.java
##########
@@ -89,7 +98,7 @@ public JavaScriptAggregatorFactory(
@Override
public Aggregator factorize(final ColumnSelectorFactory columnFactory)
{
- checkAndCompileScript();
+ compiledScript = getCompiledScript();
Review comment:
It reassigns the field again, that is not needed. Either those lines should
be
```java
JavaScriptAggregator.ScriptAggregator compiledScript = getCompiledScript();
```
Or (IMO) it's simpler just to use `getCompiledScript()` without introducing
a local variable, in methods where it's needed only once.
Same below
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
