leventov commented on a change in pull request #6662: Double-checked locking 
bugs
URL: https://github.com/apache/incubator-druid/pull/6662#discussion_r239515626
 
 

 ##########
 File path: 
processing/src/main/java/org/apache/druid/query/aggregation/JavaScriptAggregatorFactory.java
 ##########
 @@ -99,7 +108,7 @@ public Aggregator factorize(final ColumnSelectorFactory 
columnFactory)
   @Override
   public BufferAggregator factorizeBuffered(final ColumnSelectorFactory 
columnSelectorFactory)
   {
-    checkAndCompileScript();
+    compiledScript = getCompiledScript();
 
 Review comment:
   Still reassign. Also other occurrences in this PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to