jihoonson commented on a change in pull request #6629: Add support parallel
combine in brokers
URL: https://github.com/apache/incubator-druid/pull/6629#discussion_r240882394
##########
File path:
server/src/main/java/org/apache/druid/client/selector/QueryableDruidServer.java
##########
@@ -19,38 +19,16 @@
package org.apache.druid.client.selector;
-import org.apache.druid.client.DirectDruidClient;
import org.apache.druid.client.DruidServer;
+import org.apache.druid.query.QueryRunner;
/**
+ * Interface to represent a single server which can participate in query
processing. The main implementation is
+ * {@link RemoteDruidServer}.
*/
-public class QueryableDruidServer
+public interface QueryableDruidServer<T extends QueryRunner>
{
- private final DruidServer server;
- private final DirectDruidClient client;
+ DruidServer getServer();
Review comment:
This interface existed before I changed and I don't want to change it in
this PR because the refactoring was just to make it easy to write the benchmark
code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
