gianm commented on a change in pull request #6741: emit logs that are only 
useful for debugging at debug level
URL: https://github.com/apache/incubator-druid/pull/6741#discussion_r242569666
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/segment/IndexMerger.java
 ##########
 @@ -482,10 +487,13 @@ public void remove()
     @Override
     public void close()
     {
+      long mergeBufferTotalSize = 0;
       for (Pair<ByteBuffer, Integer> bufferAllocation : 
directBufferAllocations) {
-        log.info("Freeing dictionary merging direct buffer with size[%,d]", 
bufferAllocation.rhs);
+        log.debug("Freeing dictionary merging direct buffer with size[%,d]", 
bufferAllocation.rhs);
+        mergeBufferTotalSize += bufferAllocation.rhs;
         ByteBufferUtils.free(bufferAllocation.lhs);
       }
+      log.info("Freed [,%d] bytes of dictionary merging direct buffers", 
mergeBufferTotalSize);
 
 Review comment:
   Typo, should be `%,d`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to