gianm commented on a change in pull request #6741: emit logs that are only
useful for debugging at debug level
URL: https://github.com/apache/incubator-druid/pull/6741#discussion_r242570273
##########
File path:
server/src/main/java/org/apache/druid/server/coordinator/helper/DruidCoordinatorSegmentCompactor.java
##########
@@ -160,7 +160,11 @@ private CoordinatorStats doRun(
config.getTuningConfig(),
config.getTaskContext()
);
- LOG.info("Submitted a compactTask[%s] for segments[%s]", taskId,
segmentsToCompact);
+ LOG.info(
+ "Submitted a compactTask[%s] for segments[%s]",
+ taskId,
+
segmentsToCompact.stream().map(DataSegment::getIdentifier).collect(Collectors.joining(","))
Review comment:
This joiner thing looks like it would be a good utility function. Including
a space after the comma would be a good idea, too, I think, since it visually
spaces them out a bit more and would make the log line easier on the eyes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
