leventov commented on a change in pull request #6740: Zookeeper loss
URL: https://github.com/apache/incubator-druid/pull/6740#discussion_r243737400
##########
File path: server/src/main/java/org/apache/druid/curator/CuratorModule.java
##########
@@ -79,10 +81,35 @@ public CuratorFramework makeCurator(CuratorConfig config,
EnsembleProvider ensem
StringUtils.format("%s:%s", config.getZkUser(),
config.getZkPwd()).getBytes(StandardCharsets.UTF_8)
);
}
+
+ RetryPolicy retryPolicy;
+ if (config.getTerminateDruidProcess()) {
+ final Function<Void, Void> exitFunction = new Function<Void, Void>()
+ {
+ @Override
+ public Void apply(Void someVoid)
+ {
+ log.error("Zookeeper can't be reached, forcefully stopping
lifecycle...");
+ lifecycle.stop();
+ log.error("Zookeeper can't be reached, forcefully stopping virtual
machine...");
+ System.exit(1);
Review comment:
If you really want to exit,
```java
try {
log.error("Zookeeper can't be reached, forcefully stopping lifecycle...");
// Maybe wrap with call and log exception too
lifecycle.stop();
log.error("Zookeeper can't be reached, forcefully stopping virtual
machine...");
} finally {
System.exit(1);
}
```
would be more robust
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
