leventov commented on a change in pull request #6740: Zookeeper loss
URL: https://github.com/apache/incubator-druid/pull/6740#discussion_r253427401
##########
File path: server/src/main/java/org/apache/druid/curator/CuratorModule.java
##########
@@ -127,6 +154,29 @@ public EnsembleProvider
makeEnsembleProvider(CuratorConfig config, ExhibitorConf
return new FixedEnsembleProvider(config.getZkHosts());
}
+ RetryPolicy retryPolicy;
+ if (config.getTerminateDruidProcess()) {
+ final Function<Void, Void> exitFunction = new Function<Void, Void>()
+ {
+ @Override
+ public Void apply(Void aVoid)
+ {
+ log.error("Zookeeper can't be reached, forcefully stopping virtual
machine...");
+ System.exit(1);
Review comment:
@clintropolis I think the problem is that nobody knows answers to your
questions and nobody has the determination to invest the effort to research
this question (yet). I don't think we should demand this from
@michael-trelinski. I think the PR in its current form is a move in the right
direction anyway.
However, @michael-trelinski could you please add a comment in
`makeEnsembleProvider()` along the lines with ```// It's unknown whether this
precaution is needed, see
https://github.com/apache/incubator-druid/pull/6740#discussion_r243368737 for
details```?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
