jon-wei commented on a change in pull request #6761: Some fixes and tests for
spaces/non-ASCII chars in datasource names
URL: https://github.com/apache/incubator-druid/pull/6761#discussion_r244907179
##########
File path:
integration-tests/src/test/resources/indexer/wikiticker_index_task.json
##########
@@ -18,20 +18,7 @@
"dimensionsSpec": {
"dimensions": [
"channel",
- "cityName",
- "comment",
- "countryIsoCode",
- "countryName",
- "isAnonymous",
- "isMinor",
- "isNew",
- "isRobot",
- "isUnpatrolled",
- "metroCode",
- "namespace",
"page",
- "regionIsoCode",
- "regionName",
Review comment:
The full story behind this change is:
- This file is used only by `NestedQueryPushDownTest`
- This test wasn't previously being run by Travis (see the change in
`ci/travis_script_integration_part2.sh`)
- When I started running the test locally and in travis, I was getting test
timeout errors because ingesting this task's data took too long, so I shrunk
the input data by removing columns
- The tests run group by (channel, user) queries, so I kept the "page"
dimension in there to preserve some level of query time aggregation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
