jon-wei commented on a change in pull request #6761: Some fixes and tests for
spaces/non-ASCII chars in datasource names
URL: https://github.com/apache/incubator-druid/pull/6761#discussion_r244907401
##########
File path:
integration-tests/src/main/java/org/apache/druid/testing/DockerConfigProvider.java
##########
@@ -202,6 +205,12 @@ public boolean manageKafkaTopic()
{
return true;
}
+
+ @Override
+ public String getExtraDatasourceNameSuffix()
+ {
+ return extraDatasourceNameSuffix;
Review comment:
My thinking was that the non-ASCII characters could make the tests fail for
people who do not have the proper locales set up on their system. I had to
tweak locale settings on the ubuntu containers used in the integration tests
(IT setup uses a shared folder too), and people may not have any need for such
characters in their own development/use cases, so I felt it would be nice to
have a way to disable the use of such characters in the tests.
Another reason for making it a "global" thing like this is because I wanted
to easily test support across all the use cases being tested in the IT suite
(e.g., if I wanted to test support for some other characters across the board,
I can just edit this property instead of changing each test individually)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
