This is an automated email from the ASF dual-hosted git repository.
jonwei pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-druid.git
The following commit(s) were added to refs/heads/master by this push:
new 636964f Fix issue that tasks failed because of no sink for identifier
(#6724)
636964f is described below
commit 636964fcb51648f0701dd861c76f9017cc03829d
Author: Mingming Qiu <[email protected]>
AuthorDate: Sat Jan 5 09:09:11 2019 +0800
Fix issue that tasks failed because of no sink for identifier (#6724)
* Fix issue that tasks failed because of no sink for identifier
* make find sinks to persist run in one callable together with the actual
persist work
* Revert "make find sinks to persist run in one callable together with the
actual persist work"
This reverts commit a24a2d80aeaf8f047d676e7260900fe916f36b78.
---
.../druid/segment/realtime/appenderator/AppenderatorImpl.java | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git
a/server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java
b/server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java
index 9c837b0..22c1ccc 100644
---
a/server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java
+++
b/server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java
@@ -90,6 +90,7 @@ import java.util.ArrayList;
import java.util.Arrays;
import java.util.Collection;
import java.util.HashMap;
+import java.util.Iterator;
import java.util.List;
import java.util.Map;
import java.util.Set;
@@ -485,8 +486,12 @@ public class AppenderatorImpl implements Appenderator
final List<Pair<FireHydrant, SegmentIdentifier>> indexesToPersist = new
ArrayList<>();
int numPersistedRows = 0;
long bytesPersisted = 0L;
- for (SegmentIdentifier identifier : sinks.keySet()) {
- final Sink sink = sinks.get(identifier);
+ Iterator<Map.Entry<SegmentIdentifier, Sink>> iterator =
sinks.entrySet().iterator();
+
+ while (iterator.hasNext()) {
+ final Map.Entry<SegmentIdentifier, Sink> entry = iterator.next();
+ final SegmentIdentifier identifier = entry.getKey();
+ final Sink sink = entry.getValue();
if (sink == null) {
throw new ISE("No sink for identifier: %s", identifier);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]