QiuMM commented on a change in pull request #6780: Add support maxRowsPerSegment for auto compaction URL: https://github.com/apache/incubator-druid/pull/6780#discussion_r245498919
########## File path: docs/content/ingestion/compaction.md ########## @@ -77,7 +78,7 @@ An example of compaction task is This compaction task reads _all segments_ of the interval `2017-01-01/2018-01-01` and results in new segments. Since both `segmentGranularity` and `keepSegmentGranularity` are null, the original segment granularity will be remained and not changed after compaction. -To control the number of result segments per time chunk, you can set `targetPartitionSize` or `numShards`. See [indexTuningConfig](../ingestion/native_tasks.html#tuningconfig) for more details. +To control the number of result segments per time chunk, you can set `maxRowsPerSegment` or `numShards`. See [indexTuningConfig](../ingestion/native_tasks.html#tuningconfig) for more details. Review comment: The same, there is no `maxRowsPerSegment` and `numShards` for compaction tuningConfig. The `maxRowsPerSegment` is at the same level with `targetCompactionSizeBytes`, not in tuningConfig. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
