gianm commented on a change in pull request #6302: Add SQL id, request logs,
and metrics
URL: https://github.com/apache/incubator-druid/pull/6302#discussion_r246145924
##########
File path: processing/src/main/java/org/apache/druid/query/BaseQuery.java
##########
@@ -224,13 +225,25 @@ public boolean getContextBoolean(String key, boolean
defaultValue)
@Override
public String getId()
{
- return (String) getContextValue(QUERYID);
+ return (String) getContextValue(QUERY_ID);
}
@Override
public Query withId(String id)
{
- return withOverriddenContext(ImmutableMap.of(QUERYID, id));
+ return withOverriddenContext(ImmutableMap.of(QUERY_ID, id));
+ }
+
+ @Override
Review comment:
Should this be annotated with `@Nullable`? Can `SQL_QUERY_ID` be missing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
