jon-wei commented on a change in pull request #6581: Moments Sketch custom aggregator URL: https://github.com/apache/incubator-druid/pull/6581#discussion_r246214699
########## File path: processing/src/main/java/org/apache/druid/query/aggregation/AggregatorUtil.java ########## @@ -110,6 +110,13 @@ public static final byte HLL_SKETCH_TO_STRING_CACHE_TYPE_ID = 0x31; public static final byte HLL_SKETCH_TO_ESTIMATE_AND_BOUNDS_CACHE_TYPE_ID = 0x32; + // Quantiles sketch in momentsketch extension + public static final byte MOMENTS_SKETCH_BUILD_CACHE_TYPE_ID = 0x33; + public static final byte MOMENTS_SKETCH_MERGE_CACHE_TYPE_ID = 0x34; + public static final byte MOMENTS_SKETCH_TO_QUANTILES_CACHE_TYPE_ID = 0x35; Review comment: The quantiles/min/max are post-aggs, so those IDs should be defined in `PostAggregatorIds` instead ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
