gianm commented on a change in pull request #6833: fix parquet parse
performance issue
URL: https://github.com/apache/incubator-druid/pull/6833#discussion_r246645497
##########
File path:
extensions-core/parquet-extensions/src/main/java/org/apache/druid/data/input/parquet/simple/ParquetGroupConverter.java
##########
@@ -62,6 +62,10 @@ private static Object convertField(Group g, String
fieldName, boolean binaryAsSt
final int fieldIndex = g.getType().getFieldIndex(fieldName);
+ if (!(g.getFieldRepetitionCount(fieldIndex) > 0)) {
Review comment:
Ouch why not `<=`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
