drcrallen commented on issue #6370: Introduce SegmentId class URL: https://github.com/apache/incubator-druid/pull/6370#issuecomment-453190047 The issue I have with putting metadata inside a string inside an object is that there is no structure to the metadata anymore. In other words you are putting serialization mechanisms inside of serialization mechanisms which almost always leads to pain down the line when some corner of the system behaves differently than expected. The serialization system within druid is json. As such, any metadata is expected to be expressed as json, with the ability for Jackson to deserialize it into objects for consumption in the code. One of the few exceptions to this are places with URIs in the json because the URIs are usually generated or indicative of systems outside of druid.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
