drcrallen commented on issue #6370: Introduce SegmentId class URL: https://github.com/apache/incubator-druid/pull/6370#issuecomment-452005420 > SegmentId is not just "id", it's a useful metadata container Is there a way we can avoid that? What I'm asking is if we can remove the string ID completely to avoid such a temptation. Having metadata serialization for machine consumption inside of a string is almost always problematic in the future. Having it *ONLY* for human consumption would be OK. `io.druid.query.spec.MultipleSpecificSegmentSpec` already references `io.druid.query.SegmentDescriptor`, which is mostly duplicated in `SegmentIdWithShardSpec`. Any need for a difference between the two classes is not clear. As such, can they be reconciled into a single metadata class that identifies whatever needs to be identified?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
