zhaojiandong commented on a change in pull request #6868: Fix deadlock in
DruidStatement & DruidConnection
URL: https://github.com/apache/incubator-druid/pull/6868#discussion_r248171457
##########
File path: sql/src/main/java/org/apache/druid/sql/avatica/DruidStatement.java
##########
@@ -306,11 +306,11 @@ public boolean isDone()
@Override
public void close()
{
- synchronized (lock) {
- final State oldState = state;
- state = State.DONE;
+ final State oldState = state;
Review comment:
You're right this is an unsafe read, should be put into synchronized block
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
