leventov commented on a change in pull request #6397: Adds bloom filter
aggregator to 'druid-bloom-filters' extension
URL: https://github.com/apache/incubator-druid/pull/6397#discussion_r248254874
##########
File path:
extensions-core/druid-bloom-filter/src/main/java/org/apache/druid/guice/BloomFilterExtensionModule.java
##########
@@ -40,6 +40,8 @@
@Override
public void configure(Binder binder)
{
- SqlBindings.addOperatorConversion(binder,
BloomFilterOperatorConversion.class);
+ if (binder != null) {
Review comment:
Why this? `binder` should be annotated `@Nullable`. Should a similar change
be made throughout the codebase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
