leventov commented on a change in pull request #6397: Adds bloom filter aggregator to 'druid-bloom-filters' extension URL: https://github.com/apache/incubator-druid/pull/6397#discussion_r250559677
########## File path: extensions-core/druid-bloom-filter/src/main/java/org/apache/druid/query/aggregation/bloom/BloomFilterMergeAggregator.java ########## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.aggregation.bloom; + +import org.apache.druid.query.filter.BloomKFilter; +import org.apache.druid.segment.ColumnValueSelector; + +import java.io.IOException; +import java.nio.ByteBuffer; + +public class BloomFilterMergeAggregator extends BaseBloomFilterAggregator +{ + private final ColumnValueSelector<BloomKFilter> selector; + + public BloomFilterMergeAggregator(ColumnValueSelector<BloomKFilter> selector, int maxNumEntries) + { + super(new BloomKFilter(maxNumEntries)); + this.selector = selector; + } + + @Override + public void aggregate() + { + Object other = selector.getObject(); + if (other != null) { + if (other instanceof BloomKFilter) { + collector.merge((BloomKFilter) other); + } else if (other instanceof ByteBuffer) { + // fun fact: because bloom filter agg factory deserialize returns a byte buffer to avoid unnecessary serde, + // but group by v1 ends up trying to merge bytebuffers from buffer aggs with this agg instead of the buffer Review comment: Please refer as `GroupByQueryEngine (so-called groupBy V1)` to ease navigation and for clarity. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
