leventov commented on a change in pull request #6397: Adds bloom filter aggregator to 'druid-bloom-filters' extension URL: https://github.com/apache/incubator-druid/pull/6397#discussion_r250590617
########## File path: extensions-core/druid-bloom-filter/src/main/java/org/apache/druid/query/aggregation/bloom/BloomFilterMergeAggregatorFactory.java ########## @@ -0,0 +1,81 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.aggregation.bloom; + +import org.apache.druid.java.util.common.ISE; +import org.apache.druid.query.aggregation.Aggregator; +import org.apache.druid.query.aggregation.AggregatorFactory; +import org.apache.druid.query.aggregation.AggregatorUtil; +import org.apache.druid.query.aggregation.BufferAggregator; +import org.apache.druid.query.cache.CacheKeyBuilder; +import org.apache.druid.query.filter.BloomKFilter; +import org.apache.druid.segment.ColumnSelectorFactory; +import org.apache.druid.segment.ColumnValueSelector; +import org.apache.druid.segment.NilColumnValueSelector; + +import java.nio.ByteBuffer; +import java.util.Collections; +import java.util.List; + +public class BloomFilterMergeAggregatorFactory extends BloomFilterAggregatorFactory +{ + private final String fieldName; + + BloomFilterMergeAggregatorFactory(String name, String field, Integer maxNumEntries) + { + super(name, null, maxNumEntries); + this.fieldName = field; + } + + @Override + public Aggregator factorize(final ColumnSelectorFactory metricFactory) + { + final ColumnValueSelector<BloomKFilter> selector = metricFactory.makeColumnValueSelector(fieldName); + if (selector instanceof NilColumnValueSelector) { + throw new ISE("WTF?! Unexpected NilColumnValueSelector"); Review comment: I just noticed that this is the merge aggregator. Then it probably makes sense, but there should be a comment and the error message should be more descriptive. But then it appears that `BloomFilterAggregatorFactory` doesn't special-case `NilColumnValueSelector`, however it probably should for performance. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
