jihoonson commented on a change in pull request #6883: Deprecate NoneShardSpec
URL: https://github.com/apache/incubator-druid/pull/6883#discussion_r250813796
##########
File path: core/src/main/java/org/apache/druid/timeline/DataSegment.java
##########
@@ -146,7 +146,7 @@ public DataSegment(
// dataSource
this.dimensions = prepareDimensionsOrMetrics(dimensions,
DIMENSIONS_INTERNER);
this.metrics = prepareDimensionsOrMetrics(metrics, METRICS_INTERNER);
- this.shardSpec = (shardSpec == null) ? NoneShardSpec.instance() :
shardSpec;
+ this.shardSpec = (shardSpec == null) ? new NumberedShardSpec(0, 1) :
shardSpec;
Review comment:
Well, we can. But I think it would be not common to create a dataSegment
with null shardSpec. I guess this code is just for backward compatibility to
support a really old version of dataSegment. In recent versions, every
dataSegment must have a proper shardSpec.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
