jihoonson commented on a change in pull request #6883: Deprecate NoneShardSpec
URL: https://github.com/apache/incubator-druid/pull/6883#discussion_r250819828
##########
File path: core/src/main/java/org/apache/druid/timeline/DataSegment.java
##########
@@ -146,7 +146,7 @@ public DataSegment(
// dataSource
this.dimensions = prepareDimensionsOrMetrics(dimensions,
DIMENSIONS_INTERNER);
this.metrics = prepareDimensionsOrMetrics(metrics, METRICS_INTERNER);
- this.shardSpec = (shardSpec == null) ? NoneShardSpec.instance() :
shardSpec;
+ this.shardSpec = (shardSpec == null) ? new NumberedShardSpec(0, 1) :
shardSpec;
Review comment:
Oh, `DataSegment.Builder` is mostly for benchmark or unit tests. It's not
supposed to be used in production codes.
I don't think the builder pattern is appropriate for DataSegment because it
requires for every fields to be filled except `loadSpec` in its constructor.
But, it's quite prevalent in unit tests, so I left it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
