gianm commented on a change in pull request #6917:
#6714-Implement-KCL-Deaggregation
URL: https://github.com/apache/incubator-druid/pull/6917#discussion_r251275619
##########
File path:
extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java
##########
@@ -747,6 +702,40 @@ private String
getSequenceNumberInternal(StreamPartition<String> partition, Stri
}
+ @VisibleForTesting
+ List<byte[]> deaggregateKinesisRecord(Record kinesisRecord) throws
InvalidProtocolBufferException {
Review comment:
Not really a good one. That's usually what `@VisibleForTesting` means: "I
would have made this private, except I needed to call it in a unit test."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
