leventov commented on issue #6893: Add several missing inspectRuntimeShape() calls URL: https://github.com/apache/incubator-druid/pull/6893#issuecomment-458093779 @AlexanderSaydakov I should also add that the runtime shape affecting parameter should preferably be quantified, as if ```java if (lgK < 5) { execute some logic } else { execute some entirely different logic } ``` The inspecting code should be like ```java inspector.visit("lgK", lgK < 5 ? "less than 5" : "greater than 5"); ``` rather than `inspector.visit("lgK", lgK);` (what I added to the code as of now). The consequences of not following this principle are the same as I described of "inspecting something extra".
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
