gianm commented on a change in pull request #6916: Add master/data/query server concepts to docs/packaging URL: https://github.com/apache/incubator-druid/pull/6916#discussion_r251387928
########## File path: docs/content/operations/process-colocation.md ########## @@ -0,0 +1,52 @@ +--- +layout: doc_page +title: "Process Colocation" +--- + +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. + --> + +# Process Colocation Review comment: IMO, it'd be better to remove this doc and either incorporate its contents into design/index.md _or_ to shorten what's in design/index.md and break out most of the content from the "Server Types" section into a new doc (maybe design/processes.md), and incorporate this content into that new page. The rationale for this suggestion is that it would be easier for users to grasp the concepts around server and process types if a single page spelled out all the info they need. There's enough stuff here that probably the second makes sense: shortening what's in design/index.md and creating a design/processes.md that discusses server types and processes in more detail. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
