clintropolis commented on a change in pull request #6740: Zookeeper loss
URL: https://github.com/apache/incubator-druid/pull/6740#discussion_r253557523
##########
File path: server/src/main/java/org/apache/druid/curator/CuratorModule.java
##########
@@ -127,6 +154,29 @@ public EnsembleProvider
makeEnsembleProvider(CuratorConfig config, ExhibitorConf
return new FixedEnsembleProvider(config.getZkHosts());
}
+ RetryPolicy retryPolicy;
+ if (config.getTerminateDruidProcess()) {
+ final Function<Void, Void> exitFunction = new Function<Void, Void>()
+ {
+ @Override
+ public Void apply(Void aVoid)
+ {
+ log.error("Zookeeper can't be reached, forcefully stopping virtual
machine...");
+ System.exit(1);
Review comment:
Sure, I wasn't expecting a deep investigation, I was suggesting either
adding a `lifecycle.stop()` to make sure it stops cleanly and adding a comment
to explain the we aren't sure if it is needed, OR just removing it until a
scenario where an Exhibitor run Zookeeper is down but Druid doesn't kill itself
and adding this block later when we find out it is needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
