clintropolis commented on a change in pull request #6740: Zookeeper loss
URL: https://github.com/apache/incubator-druid/pull/6740#discussion_r254091751
##########
File path: server/src/main/java/org/apache/druid/curator/CuratorModule.java
##########
@@ -127,6 +154,29 @@ public EnsembleProvider
makeEnsembleProvider(CuratorConfig config, ExhibitorConf
return new FixedEnsembleProvider(config.getZkHosts());
}
+ RetryPolicy retryPolicy;
+ if (config.getTerminateDruidProcess()) {
+ final Function<Void, Void> exitFunction = new Function<Void, Void>()
+ {
+ @Override
+ public Void apply(Void aVoid)
+ {
+ log.error("Zookeeper can't be reached, forcefully stopping virtual
machine...");
+ System.exit(1);
Review comment:
I don't think there is question of why `makeEnsembleProvider` exists, it
provides the `EnsembleProvider` argument to `makeCurator`.
The only question I had is whether the quit on retry functionality needs to
be wired into it's failures as well as curator's failures. I believe there
should be no harm in using the injected lifecycle here as far as I can tell.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
