clintropolis commented on a change in pull request #6365: new feature: allows
user to specify timeZone in TimestampSpec
URL: https://github.com/apache/incubator-druid/pull/6365#discussion_r254156505
##########
File path:
core/src/main/java/org/apache/druid/data/input/impl/TimestampSpec.java
##########
@@ -60,12 +65,14 @@ public TimestampSpec(
@JsonProperty("column") String timestampColumn,
@JsonProperty("format") String format,
// this value should never be set for production data
- @JsonProperty("missingValue") DateTime missingValue
+ @JsonProperty("missingValue") DateTime missingValue,
+ @JsonProperty("timeZone") String timeZone
)
{
this.timestampColumn = (timestampColumn == null) ? DEFAULT_COLUMN :
timestampColumn;
this.timestampFormat = format == null ? DEFAULT_FORMAT : format;
- this.timestampConverter =
TimestampParser.createObjectTimestampParser(timestampFormat);
+ this.timeZone = (StringUtils.isBlank(timeZone)) ? DateTimes.UTC_TIMEZONE :
timeZone;
Review comment:
Maybe remove extra parenthesis on the condition?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
