clintropolis commented on a change in pull request #6365: new feature: allows
user to specify timeZone in TimestampSpec
URL: https://github.com/apache/incubator-druid/pull/6365#discussion_r254157251
##########
File path:
benchmarks/src/main/java/org/apache/druid/benchmark/FlattenJSONBenchmarkUtil.java
##########
@@ -54,7 +54,7 @@ public FlattenJSONBenchmarkUtil()
public Parser getFlatParser()
{
JSONParseSpec spec = new JSONParseSpec(
- new TimestampSpec("ts", "iso", null),
+ new TimestampSpec("ts", "iso", null, null),
Review comment:
It might have been worth considering adding an additional constructor to
`TimestampSpec` with `@VisibleForTesting` annotation so that this PR could have
a bit lighter of a footprint and not have to modify all of these tests since
they are all just passing in `null` anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
