justinborromeo commented on a change in pull request #6888: Fix num_rows in
sys.segments
URL: https://github.com/apache/incubator-druid/pull/6888#discussion_r254818873
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
##########
@@ -351,7 +352,8 @@ public void awaitInitialization() throws
InterruptedException
return builder.build();
}
- private void addSegment(final DruidServerMetadata server, final DataSegment
segment)
+ @VisibleForTesting
+ protected void addSegment(final DruidServerMetadata server, final
DataSegment segment)
Review comment:
Would this be better as package private instead of protected to minimize
scope? Since there's no subclasses in other packages, is there a need to be
protected?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
