justinborromeo commented on a change in pull request #6888: Fix num_rows in
sys.segments
URL: https://github.com/apache/incubator-druid/pull/6888#discussion_r254820006
##########
File path:
sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java
##########
@@ -550,7 +554,8 @@ private void removeServerSegment(final DruidServerMetadata
server, final DataSeg
return retVal;
}
- private void setSegmentSignature(final DataSegment segment, final
SegmentMetadataHolder segmentMetadataHolder)
+ @VisibleForTesting
+ protected void setSegmentMetadataHolder(final DataSegment segment, final
SegmentMetadataHolder segmentMetadataHolder)
Review comment:
Could this also be package-private?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
