leventov opened a new issue #7037: Abstract away BlockingQueue.offer()/poll() which notify after some period of inability to proceed URL: https://github.com/apache/incubator-druid/issues/7037 There are several places in Druid code which implement some sort of untimed `BlockingQueue.take()`, but they want to notify or log about inability to make progress, so they use `BlockingQueue.offer()`: https://github.com/apache/incubator-druid/blob/fafbc4a80e0bba0c1fbb5066b9f0ce37ffcab929/extensions-contrib/ambari-metrics-emitter/src/main/java/org/apache/druid/emitter/ambari/metrics/AmbariMetricsEmitter.java#L115-L127 https://github.com/apache/incubator-druid/blob/fafbc4a80e0bba0c1fbb5066b9f0ce37ffcab929/examples/src/main/java/org/apache/druid/examples/twitter/TwitterSpritzerFirehoseFactory.java#L165-L168 https://github.com/apache/incubator-druid/blob/fafbc4a80e0bba0c1fbb5066b9f0ce37ffcab929/extensions-core/kinesis-indexing-service/src/main/java/org/apache/druid/indexing/kinesis/KinesisRecordSupplier.java#L176-L179 https://github.com/apache/incubator-druid/blob/fafbc4a80e0bba0c1fbb5066b9f0ce37ffcab929/server/src/main/java/org/apache/druid/segment/realtime/firehose/EventReceiverFirehoseFactory.java#L376-L383 https://github.com/apache/incubator-druid/blob/fafbc4a80e0bba0c1fbb5066b9f0ce37ffcab929/extensions-contrib/graphite-emitter/src/main/java/org/apache/druid/emitter/graphite/GraphiteEmitter.java#L109-L121 They all use different strategies and patterns. It might be reasonable to extract this pattern as some sort of utility, or e. g. specify a common "timeout" in druid after which such events are logged, or a configuration might be added to choose between logging and emitting such events as alerts.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
