glasser commented on issue #6989: Behavior of index_parallel with appendToExisting=false and no bucketIntervals in GranularitySpec is surprising URL: https://github.com/apache/incubator-druid/issues/6989#issuecomment-462022295 I started! Another question about locking. In allocateNewSegment there's this comment: > List locks whenever allocating a new segment because locks might be revoked and no longer valid. But if I am reading the implementation of TaskLockbox and LockListAction correctly, revoked locks will show up in the response to a LockListAction. Should that stream have a `filter(taskLock -> !taskLock.isRevoked())` in it? Otherwise you might as well just remember the TaskLocks that were set up in isReady.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
