gianm commented on a change in pull request #6888: Fix num_rows in sys.segments URL: https://github.com/apache/incubator-druid/pull/6888#discussion_r252825311
########## File path: sql/src/main/java/org/apache/druid/sql/calcite/schema/DruidSchema.java ########## @@ -96,6 +96,7 @@ private static final int MAX_SEGMENTS_PER_QUERY = 15000; private static final long IS_PUBLISHED = 0; private static final long IS_AVAILABLE = 1; + private static final long NUM_ROWS = 0; Review comment: These three should really be called `DEFAULT_IS_PUBLISHED`, `DEFAULT_IS_AVAILABLE`, and `DEFAULT_NUM_ROWS`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
