leventov commented on a change in pull request #7038: Fix and document
concurrency of EventReceiverFirehose and TimedShutoffFirehose; Refine
concurrency specification of Firehose
URL: https://github.com/apache/incubator-druid/pull/7038#discussion_r257356827
##########
File path:
server/src/main/java/org/apache/druid/segment/realtime/firehose/EventReceiverFirehoseFactory.java
##########
@@ -249,6 +278,9 @@ private Thread createDelayedCloseExecutor()
dueToShutdownRequest = true;
}
}
+ // This is not possible unless there are bugs in the code of
EventReceiverFirehose. AssertionError could
+ // have been thrown instead, but it doesn't seem to make a lot
of sense in a background thread. Instead,
+ // we long the error and continue a loop after some pause.
if (closeTimeNs == null) {
log.error(
"A bug in EventReceiverFirehose code, "
Review comment:
It specifies that the following part is not something that a user can
affect, but rather that he should report that to Druid developers. Reworded to
make it more explicit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
