Akshat-Jain commented on code in PR #17621:
URL: https://github.com/apache/druid/pull/17621#discussion_r1921873005


##########
cloud/aws-common/src/test/java/org/apache/druid/common/aws/AWSCredentialsConfigTest.java:
##########


Review Comment:
   Thanks for the contribution!
   
   On a quick look, it seems like we can add the following lines to the 
existing tests for the same coverage improvements:
   ```java
   String filePath = "/path/to/credentials";
   properties.put(PROPERTY_PREFIX + ".fileSessionCredentials", filePath);
   .
   .
   Assert.assertEquals(filePath, credentialsConfig.getFileSessionCredentials());
   ```
   
   So I'm not sure if we need any additional tests, as they don't seem to be 
contributing towards coverage improvements IIUC.
   
   Appreciate your thoughts, thanks!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@druid.apache.org
For additional commands, e-mail: commits-h...@druid.apache.org

Reply via email to