gianm commented on code in PR #17625:
URL: https://github.com/apache/druid/pull/17625#discussion_r1922805950
##########
processing/src/main/java/org/apache/druid/guice/BuiltInTypesModule.java:
##########
@@ -72,12 +71,7 @@ public void configure(Binder binder)
@LazySingleton
public SideEffectRegisterer
initDimensionHandlerAndMvHandlingMode(DefaultColumnFormatConfig formatsConfig)
{
- if (formatsConfig.getNestedColumnFormatVersion() != null &&
formatsConfig.getNestedColumnFormatVersion() == 4) {
- DimensionHandlerUtils.registerDimensionHandlerProvider(
- NestedDataComplexTypeSerde.TYPE_NAME,
- new NestedColumnV4HandlerProvider()
- );
- } else {
+ if (formatsConfig.getNestedColumnFormatVersion() == null ||
formatsConfig.getNestedColumnFormatVersion() == 5) {
Review Comment:
IMO, we shouldn't fail if a user provides `formatVersion: 4`, b/c the format
version is provided in ingestion specs and this will cause previously-working
ingestion specs to stop working after an upgrade. It's OK if a validation
prevents the server from starting up completely, but it's IMO less OK if a
validation allows the server to start up but then breaks certain operations
that used to work. Better to log a warning, IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
