cryptoe commented on code in PR #17625:
URL: https://github.com/apache/druid/pull/17625#discussion_r1919518862
##########
processing/src/main/java/org/apache/druid/guice/BuiltInTypesModule.java:
##########
@@ -72,12 +71,7 @@ public void configure(Binder binder)
@LazySingleton
public SideEffectRegisterer
initDimensionHandlerAndMvHandlingMode(DefaultColumnFormatConfig formatsConfig)
{
- if (formatsConfig.getNestedColumnFormatVersion() != null &&
formatsConfig.getNestedColumnFormatVersion() == 4) {
- DimensionHandlerUtils.registerDimensionHandlerProvider(
- NestedDataComplexTypeSerde.TYPE_NAME,
- new NestedColumnV4HandlerProvider()
- );
- } else {
+ if (formatsConfig.getNestedColumnFormatVersion() == null ||
formatsConfig.getNestedColumnFormatVersion() == 5) {
Review Comment:
I was hoping there would be a place where we fail the query/service if
nestedColVersion is set to 4. Could not find such a guardrail. Is that not
required ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
