writer-jill commented on code in PR #17658:
URL: https://github.com/apache/druid/pull/17658#discussion_r1930597820


##########
docs/querying/sql-functions.md:
##########
@@ -1282,21 +1282,74 @@ Returns the following:
 
 ## BLOOM_FILTER
 
-Computes a Bloom filter from values produced by the specified expression.
+Computes a [bloom filter](../development/extensions-core/bloom-filter.md) from 
values provided in an expression.
 
-* **Syntax**: `BLOOM_FILTER(expr, <NUMERIC>)`
+`numEntries` specifies the maximum number of distinct values before the false 
positive rate increases.
+
+* **Syntax:** `BLOOM_FILTER(expr, numEntries)`
 * **Function type:** Aggregation
 
+<details><summary>Example</summary>
+
+The following example returns a base64-encoded bloom filter string for entries 
in `agent_category`:

Review Comment:
   Yes I think so. I was following another doc but we've been very inconsistent 
about it. Updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to