lejinghu opened a new issue, #17692:
URL: https://github.com/apache/druid/issues/17692

   Please provide a detailed title (e.g. "Broker crashes when using TopN query 
with Bound filter" instead of just "Broker crashes").
   
   ### Affected Version
   
   31.0
   
   ### Description
   
   #### Issue
   
   We noticed compaction configs for multiple tables were deleted after 
upgrading to Druid 31.0.
   
   The history of the configs indicate they were removed by the coordinator:
   
    {
           "globalConfig": ...
           "compactionConfig": null,
           "auditInfo": {
               "author": "KillCompactionConfig",
               "identity": "KillCompactionConfig",
               "comment": "CoordinatorDuty for automatic deletion of compaction 
config",
               "ip": ""
           },
           "auditTime": ...
       }
   
   Although the documentation states "druid.coordinator.kill.compaction.on" is 
false by default 
(https://druid.apache.org/docs/latest/configuration/#metadata-management), it 
seems it is true by default.
   
   #### Investigation
   
   In Druid 29, the compaction kill is false by default
   
   
https://github.com/apache/druid/blob/druid-29.0.1/server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinatorConfig.java
   
   @Config("druid.coordinator.kill.compaction.on")
     @Default("false")
     public abstract boolean isCompactionKillEnabled();
   
   
   But after the refactoring in Druid 31, the compaction takes the default 
config, which seems to be true by default
   
   
https://github.com/apache/druid/blob/druid-31.0.0/server/src/main/java/org/apache/druid/server/coordinator/config/CoordinatorKillConfigs.java
   
    this.compactionConfigs = Configs.valueOrDefault(compactionConfigs, 
MetadataCleanupConfig.DEFAULT);


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to