ashwintumma23 commented on code in PR #17689:
URL: https://github.com/apache/druid/pull/17689#discussion_r1939957785
##########
extensions-contrib/prometheus-emitter/src/main/resources/defaultMetrics.json:
##########
@@ -1,5 +1,5 @@
{
- "query/time" : { "dimensions" : ["dataSource", "type"], "type" : "timer",
"conversionFactor": 1000.0, "help": "Seconds taken to complete a query."},
+ "query/time" : { "dimensions" : ["dataSource", "type"], "type" : "timer",
"conversionFactor": 1000.0, "histogramBuckets": [0.1, 0.25, 0.5, 0.75, 1.0,
2.5, 5.0, 7.5, 10.0, 30.0, 60.0, 120.0, 300.0], "help": "Seconds taken to
complete a query."},
Review Comment:
Thanks @capistrant ! What do you think the default values can be? I am
thinking `[1.0, 2.5, 5.0, 7.5, 10.0, 30.0, 60.0, 120.0, 300.0, +Inf]` to
capture . But again, this is only a sample use case.
On another thought, do we need to specify an example default value here, or
let users/ cluster administrators configure it as they see fit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
