capistrant commented on code in PR #17689:
URL: https://github.com/apache/druid/pull/17689#discussion_r1940026468
##########
extensions-contrib/prometheus-emitter/src/main/resources/defaultMetrics.json:
##########
@@ -1,5 +1,5 @@
{
- "query/time" : { "dimensions" : ["dataSource", "type"], "type" : "timer",
"conversionFactor": 1000.0, "help": "Seconds taken to complete a query."},
+ "query/time" : { "dimensions" : ["dataSource", "type"], "type" : "timer",
"conversionFactor": 1000.0, "histogramBuckets": [0.1, 0.25, 0.5, 0.75, 1.0,
2.5, 5.0, 7.5, 10.0, 30.0, 60.0, 120.0, 300.0], "help": "Seconds taken to
complete a query."},
Review Comment:
I think only administrators will truly know the proper values to put. If we
show an example of how to override, I think that this metric is a good choice
though as it should make sense to operators. I would personally add `600, 1200,
1800` on to the end of the override, but that is just based off of me and how
we have longer running batch jobs that I'd prefer don't all get tossed into
inf.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
