Akshat-Jain commented on code in PR #17700: URL: https://github.com/apache/druid/pull/17700#discussion_r1945966204
########## .github/scripts/create-jacoco-coverage-report.sh: ########## @@ -0,0 +1,64 @@ +#!/bin/bash + +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. +# The ASF licenses this file to You under the Apache License, Version 2.0 +# (the "License"); you may not use this file except in compliance with +# the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. + +set -e +set -x + +echo "GITHUB_BASE_REF: ${GITHUB_BASE_REF}" + +echo "Setting up git remote" +git remote set-branches --add origin ${GITHUB_BASE_REF} +git fetch + Review Comment: Yes GITHUB_BASE_REF is a standard GitHub Actions variable. As discussed offline, we already were using it, so it shouldn't cause any issues when the check is running on a branch. > I wonder if we could add this worker.yml instead of doing the same in the the jacoco related script This wasn't required for anything other than the jacoco script, so I put it there. I think we can consider moving it to a common place like worker.yml, when this is required by some other thing in the future. Hope that works! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
