kgyrtkirk commented on code in PR #17700: URL: https://github.com/apache/druid/pull/17700#discussion_r2078961947
########## processing/src/test/java/org/apache/druid/query/topn/TopNQueryRunnerBenchmark.java: ########## @@ -46,6 +46,7 @@ /** * Based on TopNQueryRunnerTest */ +@Ignore Review Comment: * this seems like a benchmark and not a test * its misplaced as its in processing and not in benchmarks * iirc there are other ignored benchmarks around here...so addoing it for this one was just following an existing pattern * I don't fully recall why it come into sight; but migrating it to benchmarks was considered...but it was not that simple * you could probably narrow down and fix the issue it may have found -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
