kfaraz commented on code in PR #17702:
URL: https://github.com/apache/druid/pull/17702#discussion_r1946041952
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -1692,12 +1692,11 @@ public void runInternal()
// if suspended, ensure tasks have been requested to gracefully stop
if
(stateManager.getSupervisorState().getBasicState().equals(SupervisorStateManager.BasicState.STOPPING))
{
// if we're already terminating, don't do anything here, the
terminate already handles shutdown
- log.info("[%s] supervisor is already stopping.", dataSource);
+ log.debug("[%s] supervisor is already stopping.", dataSource);
} else if (stateManager.isIdle()) {
- log.info("[%s] supervisor is idle.", dataSource);
+ log.debug("[%s] supervisor is idle.", dataSource);
Review Comment:
```suggestion
log.debug("Supervisor[%s] is idle.", dataSource);
```
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -1692,12 +1692,11 @@ public void runInternal()
// if suspended, ensure tasks have been requested to gracefully stop
if
(stateManager.getSupervisorState().getBasicState().equals(SupervisorStateManager.BasicState.STOPPING))
{
// if we're already terminating, don't do anything here, the
terminate already handles shutdown
- log.info("[%s] supervisor is already stopping.", dataSource);
+ log.debug("[%s] supervisor is already stopping.", dataSource);
Review Comment:
```suggestion
log.debug("Supervisor[%s] is already stopping.", dataSource);
```
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -3718,7 +3717,15 @@ && computeTotalLag() == 0) {
if (!idle) {
stateManager.maybeSetState(SupervisorStateManager.BasicState.RUNNING);
} else if (!stateManager.isIdle() && idleTime >
idleConfig.getInactiveAfterMillis()) {
+ log.info("Setting supervisor[%s] to state[%s]", supervisorId,
SupervisorStateManager.BasicState.IDLE.name());
Review Comment:
Would just this suffice?
```suggestion
log.info("Setting supervisor[%s] to idle");
```
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/supervisor/SeekableStreamSupervisor.java:
##########
@@ -1692,12 +1692,11 @@ public void runInternal()
// if suspended, ensure tasks have been requested to gracefully stop
if
(stateManager.getSupervisorState().getBasicState().equals(SupervisorStateManager.BasicState.STOPPING))
{
// if we're already terminating, don't do anything here, the
terminate already handles shutdown
- log.info("[%s] supervisor is already stopping.", dataSource);
+ log.debug("[%s] supervisor is already stopping.", dataSource);
} else if (stateManager.isIdle()) {
- log.info("[%s] supervisor is idle.", dataSource);
+ log.debug("[%s] supervisor is idle.", dataSource);
} else if (!spec.isSuspended()) {
- log.info("[%s] supervisor is running.", dataSource);
-
+ log.debug("[%s] supervisor is running.", dataSource);
Review Comment:
```suggestion
log.debug("Supervisor[%s] is running.", dataSource);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
