kgyrtkirk opened a new pull request, #17726: URL: https://github.com/apache/druid/pull/17726
* `JoinDataSource` uses `DataSourceAnalysis` as a model - but during construction it ignores some other typed `DataSource`-s * there was a hack to possibly make those work - but it could have been easily happened that it just forgot to call the `createSegmentMapFunction` on those sources * at the same time `DataSourceAnalysis` also acts as a vertex-boundary like object; which makes this a bit more complicated. This change is limited to fix the bug: I think in a followup will be needed to create a separate object which could be used inside the join - and a separate one to work with the boundary - the `DataSource#getAnalysis` was being used at a lot of places so the bugfix was separated for now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
