kgyrtkirk commented on code in PR #17726:
URL: https://github.com/apache/druid/pull/17726#discussion_r1963582189
##########
processing/src/main/java/org/apache/druid/query/Queries.java:
##########
@@ -161,21 +161,18 @@ public static <T> Query<T> withSpecificSegments(final
Query<T> query, final List
retVal = query.withDataSource(new
QueryDataSource(withSpecificSegments(subQuery, descriptors)));
} else {
retVal = query.withQuerySegmentSpec(new
MultipleSpecificSegmentSpec(descriptors));
- }
Review Comment:
Earlier it was able to traverse even `QueryDataSource`-es ; so it was
available more widely.
The change here is that the `getEffectiveQuery` means `The applicable {@link
QuerySegmentSpec} for this vertex.` ; so it only considers queries belonging to
the current vertex.
The other interpretation also has a valuable meaning ; but I've not seen any
need for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
