FrankChen021 commented on PR #17731: URL: https://github.com/apache/druid/pull/17731#issuecomment-2665818087
> I was taking a look and was wondering about the following: > > * I feel like the `BUILD_FROM_SOURCE` option is very wierd; why build these inside docker instead of packaging the realse into a docker image? > ** is it possible with an M1 to build the dist build on the host and avoid building inside docker? the BUILD_FROM_SOURCE is a legacy feature that I didn't make change and keep it. However, this is how I built the docker image on my M1 when building docker directly takes long time. The problem for M1 is that buliding a docker images is divided into two steps, first building distribution jar on host machine, then using this environment to build a docker image. This should be fixed because sometimes i even can't remember i should follow these two steps to get a docker image. > * I don't really like that the new docker build customizes the distribution build logic inside the Dockerfile - with the hazard of using differently versioned tools The core problem here is that web-console is different from backend services, it's a front-end project that has its own building toolchain > * I think the `web-console` module doesn't correctly support incremental builds; so it gets rebuild every time; I think fixing that would also make these things painfull - using the docker cache implicitly adds a incremental build option... This is why I made some changes to the web-console module so that we can use the docker cache -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
