gianm commented on PR #17731: URL: https://github.com/apache/druid/pull/17731#issuecomment-2768688041
I have to admit, I don't fully understand how the docker images are built. I also don't use docker in my personal development flow, so I don't have much to add on the core aspects of this PR. But, two tangential things caught my eye: 1) > web-console depends on node-sass (but doesn't use it AFAIK) > node-sass is [not maintained](https://sass-lang.com/blog/node-sass-is-end-of-life/) If we don't use it, could we remove it? Especially since it's EOL. I don't understand why it is there, if it causes all these problems and isn't being used. 2) If the `maven-build-cache-extension` from https://github.com/kgyrtkirk/druid/tree/build-cache-try is good, could we add it to `master`? Is there any reason not to? I also wonder - @FrankChen021 - hypothetically, if the web console build issues are fixed outside of the Docker system (perhaps by removing node-sass and using this build cache), does that solve your problem? Or would you still want to modify the Docker build system? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
